This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
feat: Improve RFQ-T logging #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deploy staging |
steveklebanoff
approved these changes
May 12, 2020
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates logging to support the operational monitoring of RFQ-T usage.
Re-pins to an updated
asset-swapperwith similar changes.Testing Instructions
View new logging in output of existing (mocha) tests. Below are some examples from the latest CI run of this PR. For each text log entry I've included a nice visual rendering to go with it.
{"level":"info","time":1589240068300,"pid":5145,"hostname":"e6c519a5c290","firmQuoteServed":{"taker":"0x6ecbe1db9ef729cbe972c83fb886247691fb6beb","apiKey":"koolApiKey1","buyToken":"ZRX","sellToken":"WETH","sellAmount":"100000000000000000","makers":["0x5409ED021D9299bf6814279A6A1411A7e866A631"]},"v":1}{"level":"info","time":1589240069170,"pid":5145,"hostname":"e6c519a5c290","indicativeQuoteServed":{"taker":"0x6ecbe1db9ef729cbe972c83fb886247691fb6beb","apiKey":"koolApiKey1","buyToken":"ZRX","sellToken":"WETH","sellAmount":"100000000000000000","makers":["0x0000000000000000000000000000000000000000"]},"v":1}And for completion here's the rendering of the logs in that asset swapper PR:
{"level":"info","time":1589240066372,"pid":5145,"hostname":"e6c519a5c290","rfqtMakerInteraction":{"url":"https://mock-rfqt1.club","quoteType":"firm","requestParams":{"takerAddress":"0x6ecbe1db9ef729cbe972c83fb886247691fb6beb","buyToken":"0x871dd7c2b4b25e1aa18728e9d5f2af4c4e431f5c","sellToken":"0x0b1ba0af832d7c05fd64161e0db78e85978e8082","sellAmount":"100000000000000000"},"response":{"statusCode":200,"latencyMs":4}},"v":1}