-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collapse strategy to PartialTrie
variants
#501
Conversation
Co-authored-by: BGluth <[email protected]>
Hey just for some more info, how are we handling this in the decoder? Isn't this something that must be done in the full node? Like if the decoder realizes that an extension will collapse into a |
Jerry confirmed that this is always handled by Jerigon, hence the rationale behind ignoring these edge-cases from Jerigon payloads and only trigger errors from native client ones. |
@Nashtare Ah ok. So, if I'm understanding this right, even if Jerigon is handling this, under normal circumstances, we should never trigger the logic to collapse a |
Not quite, with jerigon payloads, Jerry guaranteed that having this orphaned hash node converted to an extension node will never cause inconsistent trie root, unlike what we were having on frisitano's issue. I have Jerigon payload examples that were triggering these false positives, but were sane to handle for hte prover. |
Ah gotcha, makes sense! |
Add a collapsing strategy for the edge case of a branch node with two children being collapsed into an extension node after the deletion of one the children.
cf #202 and #455 for reference
@0xaatif I don't consider the PR ready yet, especially some more doc/clarification would be good but I'm opening it to get some feedback regarding the approach taken and if it matches how you were envisioning it following our chat.