Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use alloy instead of ethers and primitive_types #229

Closed
0xaatif opened this issue May 15, 2024 · 2 comments
Closed

Use alloy instead of ethers and primitive_types #229

0xaatif opened this issue May 15, 2024 · 2 comments
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: mpt_trie Anything related to the mpt_trie crate. crate: proof_gen Anything related to the proof_gen crate. crate: trace_decoder Anything related to the trace_decoder crate. good first issue Good for newcomers
Milestone
System strengthening

Comments

@0xaatif
Copy link
Contributor

0xaatif commented May 15, 2024

In zero-bin#70 we're moving to alloy.

In eth-tx-proof we have to perform conversions to interface with crates in this repo. WIBNI if we didn't
@0xaatif 0xaatif added crate: trace_decoder Anything related to the trace_decoder crate. crate: proof_gen Anything related to the proof_gen crate. crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: mpt_trie Anything related to the mpt_trie crate. labels May 15, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM May 15, 2024
@0xaatif 0xaatif mentioned this issue May 15, 2024
Closed
@Nashtare

This comment was marked as resolved.

Sign in to view
@Nashtare Nashtare mentioned this issue May 21, 2024
Closed
@Nashtare Nashtare mentioned this issue Jun 11, 2024
Open
18 tasks
@Nashtare Nashtare added this to the Cleanups and Misc. milestone Jun 14, 2024
@Nashtare Nashtare mentioned this issue Jul 11, 2024
Closed
@Nashtare Nashtare modified the milestones: Misc., System strengthening Jul 12, 2024
@Nashtare Nashtare mentioned this issue Aug 7, 2024
Open
@Nashtare Nashtare added the good first issue Good for newcomers label Aug 13, 2024
@Nashtare Nashtare mentioned this issue Aug 31, 2024
Merged
@0xaatif 0xaatif moved this from Backlog to Todo in Zero EVM Aug 31, 2024
@0xPolygonZero 0xPolygonZero deleted a comment from GIgako19929 Sep 15, 2024
@sergerad sergerad mentioned this issue Nov 4, 2024
Closed
@Nashtare Nashtare linked a pull request Nov 5, 2024 that will close this issue
WIP: Convert ethereum_types, rlp, etc to alloy equivalents #766
Closed
@sergerad sergerad mentioned this issue Nov 5, 2024
Merged
@0xaatif 0xaatif mentioned this issue Nov 13, 2024
Merged
@Nashtare
Copy link
Collaborator

Won't do (keeping the compatibility crate for now, as conversion is too painful).

@Nashtare Nashtare closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Zero EVM Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: mpt_trie Anything related to the mpt_trie crate. crate: proof_gen Anything related to the proof_gen crate. crate: trace_decoder Anything related to the trace_decoder crate. good first issue Good for newcomers
Projects
Zero EVM
Status: Done
Milestone
System strengthening
Development

Successfully merging a pull request may close this issue.

WIP: Convert ethereum_types, rlp, etc to alloy equivalents sergerad/zk_evm
2 participants
@Nashtare @0xaatif