Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set read wrire addresses from final root #337

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

krlosMata
Copy link
Contributor

  • balance/nonce of all addresses touched during the execution are saved
  • the case when there is an exception during the execution (example: OOG ) and a state root is recovered, those accounts where not properly updated since they are not accessed anymore
  • Fix: get the final state root at the end of the batch and query all the state for all the readWriteAddresses

@krlosMata krlosMata force-pushed the feature/read-write-final-root branch from 0237e06 to a2da63a Compare April 16, 2024 17:10
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes

Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ignasirv ignasirv self-requested a review April 18, 2024 10:50
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ignasirv ignasirv merged commit 44e3954 into develop Apr 18, 2024
3 of 4 checks passed
ignasirv added a commit that referenced this pull request Apr 18, 2024
…-root

set read wrire addresses from final root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants