Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve AddTxTracker Function Bug in Worker Module #2342

Closed
Psykepro opened this issue Jul 31, 2023 · 0 comments
Closed

Resolve AddTxTracker Function Bug in Worker Module #2342

Psykepro opened this issue Jul 31, 2023 · 0 comments
Assignees
Labels
bug Something isn't working sequencer
Milestone

Comments

@Psykepro
Copy link
Contributor

Overview:

A bug has been identified in the Worker's AddTxTracker function where a new AddrQueue is created for an address, just after its transactions have expired, but before the pending transactions for the same address are stored. As a result, the new AddrQueue is incorrectly initiated using oldStateRoot, old Nonce, and Balance. This bug disrupts the sequence of transactions and leads to potential data inconsistency issues and makes the sequencer to get stuck.

Recommended Changes:

  1. Modify AddTxTracker Function:
    • Adjust the AddTxTracker function in the Worker module to wait for the pending transactions to be completely stored before initiating a new AddrQueue for an address. This can be achieved by checking the status of pending transactions and delaying the AddrQueue creation until all transactions are confirmed to be stored.

Objective:

The proposed changes aim to address the identified bug in the Worker's AddTxTracker function. By modifying the function to wait for pending transactions to be stored before initiating a new AddrQueue, we ensure data consistency and prevent potential errors caused by this bug.

@Psykepro Psykepro self-assigned this Jul 31, 2023
@Psykepro Psykepro added bug Something isn't working sequencer labels Jul 31, 2023
@Psykepro Psykepro added this to the v0.2.2 milestone Jul 31, 2023
@agnusmor agnusmor modified the milestones: v0.2.2, v0.2.4 Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sequencer
Projects
None yet
Development

No branches or pull requests

2 participants