We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not enough context is given about the TX if a user submits an EIP1559 txn to a chain not supporting EIP1559.
Relevant Genesis Config Values:
{ ... "burnContract": null, "burnContractDestinationAddress": "0x0000000000000000000000000000000000000000" }
A detailed error on what about the TX is invalid and instead we get "Invalid TX Type"
Provide more verbose reasoning to why TXNs were rejected from the pool within these code blocks. Should also set a standard for any additional forks. https://github.com/0xPolygon/polygon-edge/blob/develop/txpool/txpool.go#L617-L621
geth example: https://github.com/ethereum/go-ethereum/blob/1aa5520d750147cabcb39030ac86bf31088c767f/core/txpool/validation.go#L63-L65
The text was updated successfully, but these errors were encountered:
This will be merged soon, so I am closing this. Reference PR: #1954
Sorry, something went wrong.
jelacamarko
Successfully merging a pull request may close this issue.
Not enough information for invalid TX Types for unsupported forks
Description
Not enough context is given about the TX if a user submits an EIP1559 txn to a chain not supporting EIP1559.
Steps to reproduce
Relevant Genesis Config Values:
Expected behavior
A detailed error on what about the TX is invalid and instead we get "Invalid TX Type"
Proposed solution
Provide more verbose reasoning to why TXNs were rejected from the pool within these code blocks. Should also set a standard for any additional forks.
https://github.com/0xPolygon/polygon-edge/blob/develop/txpool/txpool.go#L617-L621
geth example:
https://github.com/ethereum/go-ethereum/blob/1aa5520d750147cabcb39030ac86bf31088c767f/core/txpool/validation.go#L63-L65
The text was updated successfully, but these errors were encountered: