Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyCode.SHORTCUT not working when adding keyboard accelerators #24

Open
jkaving opened this issue Nov 18, 2022 · 0 comments · May be fixed by #25
Open

KeyCode.SHORTCUT not working when adding keyboard accelerators #24

jkaving opened this issue Nov 18, 2022 · 0 comments · May be fixed by #25

Comments

@jkaving
Copy link

jkaving commented Nov 18, 2022

Using the KeyCode.SHORTCUT constant doesn't work for adding keyboard shortcuts with the Command key.
The same issue was reported in codecentric#42 .

The shortcut key is a virtual key that is used to represent different keys on different platforms (in order to create platform-independent keyboard shortcuts). Here's a part of the Javadoc for KeyCombination:

/**
 * ...
 * The {@code shortcut} modifier is used to represent the modifier key which is
 * used commonly in keyboard shortcuts on the host platform. This is for
 * example {@code control} on Windows and {@code meta} (command key) on Mac.
 * By using {@code shortcut} key modifier developers can create platform
 * independent shortcuts. So the "Shortcut+C" key combination is handled
 * internally as "Ctrl+C" on Windows and "Meta+C" on Mac.
 * ...
 */
jkaving added a commit to jkaving/NSMenuFX that referenced this issue Nov 18, 2022
@jkaving
Handle the shortcut key like the meta key
b947c1c 
KeyCombination.shortcut is a way to add platform-independent keyboard
shortcuts that will e.g. use "Ctrl" on Windows and "Cmd" on macOS
(see the Javadoc in javafx.scene.input.KeyCombination).

This commit just adds a check for getShortcut() and sets the
NSEventModifierFlagCommand just like is already done for getMeta().

Fixes 0x4a616e#24
@jkaving jkaving linked a pull request Nov 18, 2022 that will close this issue
Open
hhu-stups-mirror pushed a commit to hhu-stups/prob2_ui that referenced this issue Sep 18, 2023
@dgelessus
Fix Preferences keyboard shortcut on macOS (bug caused by NSMenuFX 3.x)
c6a82c1 
See 0x4a616e/NSMenuFX#24.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle the shortcut key like the meta key jkaving/NSMenuFX
1 participant
@jkaving