Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persisted document id generation not working with fragments #359

Closed
3 tasks done
onionhammer opened this issue Oct 3, 2024 · 4 comments · Fixed by #360
Closed
3 tasks done

Persisted document id generation not working with fragments #359

onionhammer opened this issue Oct 3, 2024 · 4 comments · Fixed by #360

Comments

@onionhammer
Copy link

Describe the bug

When adding a fragment to a query, the persisted string is not being underscored with yellow squigglies

Without fragment:
image

With fragment:
image

If i use the hint, it puts "undefined" into the string
image

Reproduction

No response

gql.tada version

1.8.9

Validations

  • I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
  • Read the docs.
  • Follow our Code of Conduct
@JoviDeCroock JoviDeCroock transferred this issue from 0no-co/gql.tada Oct 3, 2024
@JoviDeCroock
Copy link
Member

Mind providing a reproduction or writing a test in this repository. I tried to reproduce your bug but did not succeed

@onionhammer
Copy link
Author

@JoviDeCroock sure, I also found a workaround - just adding in an empty [] after the graphql fixes it.,

No squiggly:
image

Squiggly:
image

Repro coming shortly..

@JoviDeCroock
Copy link
Member

@onionhammer I understand what's going on, give me a moment to fix it

@onionhammer
Copy link
Author

onionhammer commented Oct 3, 2024

@JoviDeCroock you're too quick, I just published the repro too lol :D

https://github.com/onionhammer/gqltada-repro/blob/master/src/App.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants