Skip to content

Commit

Permalink
mm-shmem-dont-truncate-page-if-memory-failure-happens-checkpatch-fixes
Browse files Browse the repository at this point in the history
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
torvalds#20:
 slight different implementation from what Ajay Garg <[email protected]>

WARNING: suspect code indent for conditional statements (16, 23)
torvalds#148: FILE: mm/shmem.c:3129:
+		if (!page)
+		       return ERR_PTR(-ECHILD);

WARNING: Statements should start on a tabstop
torvalds#149: FILE: mm/shmem.c:3130:
+		       return ERR_PTR(-ECHILD);

total: 0 errors, 3 warnings, 150 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/mm-shmem-dont-truncate-page-if-memory-failure-happens.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Yang Shi <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
  • Loading branch information
akpm00 authored and broonie committed Dec 15, 2021
1 parent 286b39b commit d99b8df
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mm/shmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -3127,7 +3127,7 @@ static const char *shmem_get_link(struct dentry *dentry,
if (error)
return ERR_PTR(error);
if (!page)
return ERR_PTR(-ECHILD);
return ERR_PTR(-ECHILD);
if (PageHWPoison(page)) {
unlock_page(page);
put_page(page);
Expand Down

0 comments on commit d99b8df

Please sign in to comment.