[test] Runtimes separation #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 0o-de-lally <[email protected]>
…etworkCommunity#172) Co-authored-by: 0o-de-lally <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI is a very simple process that parses command line arguments and starts a diem_node. There is no communication between diem_node and CLI moreover CLI has minimal function. So why start diem_node in the runtime of CLI?
Very stupid idea: : The CLI should spawn a process for running diem_node, the process should take over the CLI process, and close the CLI process. As a result, there are no nested runtimes the diem_node process acts like the main process. without any interface from the CLI runtime.
Implementation: Start the node into a tmux session
Future implementation: It should start the node directly in the background(the code will do all the node setups for you and just outputs if the node started) and have an option for log(a log.txt file) with maximum size and automatic cleanup. After this, you can close the server safely.