Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] community wallet fixes addressing locked out accounts #194

Merged
merged 49 commits into from
Mar 1, 2024

Conversation

0xzoz
Copy link
Contributor

@0xzoz 0xzoz commented Feb 28, 2024

Community wallets have been in an inactivated state since upgrade 6.9.0 which introduced a bug during the refactoring of donor_voice accounts. Meaning each community and their programs which had initiated such accounts could not do basic transactions, and are delayed or impeded in their activities.

This PR is an opportunity refactor the implementation and interfaces for the infrastructure for those communities' tooling, including modules: multi_auth, multisig_account, donor_voice, community_wallet.

  • Remove resource_account implementation from multi_auth, which was an incorrect implementation, causing community wallets to be inactivated.
  • Using multisig_account.move as the backend for the multi_auth.move accounts, to deduplicate multisignature tx implementations.
  • Refactoring of donor_voice and multi_action to separate state from controllers to solve dependency cycle
  • Move unit tests

@0o-de-lally 0o-de-lally changed the title [fix] community wallet fixes addressing multiple issues [fix] community wallet fixes addressing locked out accounts Feb 29, 2024
Copy link
Contributor

@kalvkusk kalvkusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xzoz 0xzoz merged commit 0c20dec into main Mar 1, 2024
22 of 24 checks passed
@0o-de-lally 0o-de-lally deleted the com-wallet-tests branch March 15, 2024 15:06
0o-de-lally added a commit that referenced this pull request Aug 8, 2024
0o-de-lally added a commit that referenced this pull request Aug 8, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally added a commit that referenced this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants