-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] community wallet fixes addressing locked out accounts #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0o-de-lally
changed the title
[fix] community wallet fixes addressing multiple issues
[fix] community wallet fixes addressing locked out accounts
Feb 29, 2024
kalvkusk
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
0o-de-lally
added a commit
that referenced
this pull request
Aug 8, 2024
Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
that referenced
this pull request
Aug 8, 2024
Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
…kCommunity#194) Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
…kCommunity#194) Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
…kCommunity#194) Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
…kCommunity#194) Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
…kCommunity#194) Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…kCommunity#194) Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…kCommunity#194) Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…kCommunity#194) Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…kCommunity#194) Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…kCommunity#194) Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…kCommunity#194) Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…kCommunity#194) Co-authored-by: 0o-de-lally <[email protected]>
0o-de-lally
added a commit
that referenced
this pull request
Aug 17, 2024
Co-authored-by: 0o-de-lally <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community wallets have been in an inactivated state since upgrade 6.9.0 which introduced a bug during the refactoring of donor_voice accounts. Meaning each community and their programs which had initiated such accounts could not do basic transactions, and are delayed or impeded in their activities.
This PR is an opportunity refactor the implementation and interfaces for the infrastructure for those communities' tooling, including modules: multi_auth, multisig_account, donor_voice, community_wallet.
resource_account
implementation from multi_auth, which was an incorrect implementation, causing community wallets to be inactivated.donor_voice
andmulti_action
to separate state from controllers to solve dependency cycle