-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Change conda build directories to work with ccache #1452
ENH Change conda build directories to work with ccache #1452
Conversation
export LIBCUGRAPH_FILE=`conda build conda/recipes/libcugraph --output` | ||
export CUGRAPH_FILE=`conda build conda/recipes/cugraph --python=$PYTHON --output` | ||
export LIBCUGRAPH_FILE=`conda build --no-build-id --croot ${CONDA_BLD_DIR} conda/recipes/libcugraph --output` | ||
export CUGRAPH_FILE=`conda build --croot ${CONDA_BLD_DIR} conda/recipes/cugraph --python=$PYTHON --output` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this line contain --no-build-id
also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--no-build-id
is only needed for libraries that are using ccache, as it prevents the random folder generation.
@@ -58,18 +59,20 @@ conda config --set ssl_verify False | |||
gpuci_logger "Build conda pkg for libcugraph" | |||
if [ "$BUILD_LIBCUGRAPH" == '1' ]; then | |||
if [[ -z "$PROJECT_FLASH" || "$PROJECT_FLASH" == "0" ]]; then | |||
conda build conda/recipes/libcugraph | |||
gpuci_conda_retry build --no-build-id --croot ${CONDA_BLD_DIR} conda/recipes/libcugraph |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought you had mentioned that gpuci_conda_retry
didn't work with the build
command. is that not the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gpuci_conda_retry
doesn't work when we use conda build to get the file output names for uploading, as it somehow has more output than intended. See cudf: https://github.com/rapidsai/cudf/blob/branch-0.19/ci/cpu/build.sh#L72
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #1452 +/- ##
============================================
Coverage 59.04% 59.04%
============================================
Files 70 70
Lines 3223 3223
============================================
Hits 1903 1903
Misses 1320 1320 Continue to review full report at Codecov.
|
@gpucibot merge |
This updates the default conda build directory to a custom path for gpuCI. Small changes to artifact paths as well to make this compatible with Project Flash.