Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Change conda build directories to work with ccache #1452

Merged
merged 6 commits into from
Mar 26, 2021

Conversation

dillon-cullinan
Copy link
Contributor

This updates the default conda build directory to a custom path for gpuCI. Small changes to artifact paths as well to make this compatible with Project Flash.

@dillon-cullinan dillon-cullinan requested a review from a team as a code owner March 15, 2021 19:49
export LIBCUGRAPH_FILE=`conda build conda/recipes/libcugraph --output`
export CUGRAPH_FILE=`conda build conda/recipes/cugraph --python=$PYTHON --output`
export LIBCUGRAPH_FILE=`conda build --no-build-id --croot ${CONDA_BLD_DIR} conda/recipes/libcugraph --output`
export CUGRAPH_FILE=`conda build --croot ${CONDA_BLD_DIR} conda/recipes/cugraph --python=$PYTHON --output`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this line contain --no-build-id also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--no-build-id is only needed for libraries that are using ccache, as it prevents the random folder generation.

@@ -58,18 +59,20 @@ conda config --set ssl_verify False
gpuci_logger "Build conda pkg for libcugraph"
if [ "$BUILD_LIBCUGRAPH" == '1' ]; then
if [[ -z "$PROJECT_FLASH" || "$PROJECT_FLASH" == "0" ]]; then
conda build conda/recipes/libcugraph
gpuci_conda_retry build --no-build-id --croot ${CONDA_BLD_DIR} conda/recipes/libcugraph
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought you had mentioned that gpuci_conda_retry didn't work with the build command. is that not the case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpuci_conda_retry doesn't work when we use conda build to get the file output names for uploading, as it somehow has more output than intended. See cudf: https://github.com/rapidsai/cudf/blob/branch-0.19/ci/cpu/build.sh#L72

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 16, 2021
@BradReesWork BradReesWork added this to the 0.19 milestone Mar 16, 2021
@codecov-io
Copy link

codecov-io commented Mar 25, 2021

Codecov Report

Merging #1452 (3deb621) into branch-0.19 (7256f32) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.19    #1452   +/-   ##
============================================
  Coverage        59.04%   59.04%           
============================================
  Files               70       70           
  Lines             3223     3223           
============================================
  Hits              1903     1903           
  Misses            1320     1320           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7256f32...3deb621. Read the comment docs.

@dillon-cullinan
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 76fad0e into rapidsai:branch-0.19 Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants