Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Update and Test Renumber bindings #1427

Merged
merged 12 commits into from
Mar 15, 2021
Merged

[REVIEW] Update and Test Renumber bindings #1427

merged 12 commits into from
Mar 15, 2021

Conversation

Iroy30
Copy link
Contributor

@Iroy30 Iroy30 commented Feb 25, 2021

No description provided.

@Iroy30 Iroy30 requested review from a team as code owners February 25, 2021 04:59
@Iroy30 Iroy30 changed the title Renumber bindings [WIP] Update and Test Renumber bindings Feb 25, 2021
@Iroy30 Iroy30 self-assigned this Feb 25, 2021
seunghwak
seunghwak reviewed Mar 3, 2021
View reviewed changes
cpp/include/utilities/cython.hpp Outdated Show resolved Hide resolved
python/cugraph/structure/new_number_map.py Show resolved Hide resolved
python/cugraph/structure/new_number_map.py Show resolved Hide resolved
python/script.py Outdated Show resolved Hide resolved
@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 5, 2021
@Iroy30 Iroy30 changed the title [WIP] Update and Test Renumber bindings [REVIEW] Update and Test Renumber bindings Mar 5, 2021
@seunghwak seunghwak mentioned this pull request Mar 8, 2021
Merged
@BradReesWork BradReesWork added this to the 0.19 milestone Mar 10, 2021
seunghwak
seunghwak approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and don't forget to create an issue about optimizing the un-renumbering step.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5e35518 into rapidsai:branch-0.19 Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@aschaffer aschaffer aschaffer approved these changes

@jnke2016 jnke2016 Awaiting requested review from jnke2016

@rlratzel rlratzel Awaiting requested review from rlratzel

Assignees

@Iroy30 Iroy30

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
0.19
Development

Successfully merging this pull request may close these issues.
5 participants
@Iroy30 @BradReesWork @aschaffer @seunghwak @rlratzel