Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*) migrate to golang 1.15 #981

Merged
merged 3 commits into from
Sep 15, 2020
Merged

chore(*) migrate to golang 1.15 #981

merged 3 commits into from
Sep 15, 2020

Conversation

nickolaev
Copy link
Contributor

@nickolaev nickolaev commented Aug 17, 2020 •
edited
Loading

Summary

Migrate to Go 1.15.x Use this PR to track the changes needed.

As noted here: golang/go#39568 (comment), we need to regenerate the certificates used in the tree

 openssl req -x509 -out localhost.crt -keyout localhost.key \
-newkey rsa:2048 -nodes -sha256 \
-subj '/CN=localhost' -extensions EXT -config <( \
printf "[dn]\nCN=localhost\n[req]\ndistinguished_name = dn\n[EXT]\nsubjectAltName=DNS:localhost\nkeyUsage=digitalSignature\nextendedKeyUsage=serverAuth")

@nickolaev nickolaev changed the title chore(*) migrate to go 1.15.0 chore(*) migrate to golang 1.15.0 Aug 17, 2020
@nickolaev nickolaev changed the title chore(*) migrate to golang 1.15.0 chore(*) migrate to golang 1.15 Aug 17, 2020
@jakubdyszkiewicz
Copy link
Contributor

Please change go.mods

Nikolay Nikolaev added 3 commits September 14, 2020 12:01
chore(*) migrate to go 1.15.0
76566e9 
Signed-off-by: Nikolay Nikolaev <[email protected]>
test(*) update certificates for the new Go requirements
cbdc122 
Signed-off-by: Nikolay Nikolaev <[email protected]>
chore(*) go 1.15.2
d3e0866 
Signed-off-by: Nikolay Nikolaev <[email protected]>
@nickolaev nickolaev marked this pull request as ready for review September 15, 2020 05:13
@nickolaev nickolaev requested a review from a team as a code owner September 15, 2020 05:13
@nickolaev nickolaev merged commit c58e4be into master Sep 15, 2020
@nickolaev nickolaev deleted the chore/go_1_15 branch September 17, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickolaev @jakubdyszkiewicz