Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp) remove + from minor version of Kubernetes so bitnami kubectl can be fetched #956

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

jakubdyszkiewicz
Copy link
Contributor

The problem was that some K8S distros (especially in clouds) has + in minor version

❯❯❯ kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:11:31Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.12-gke.2", GitCommit:"fb7add51f767aae42655d39972210dc1c5dbd4b3", GitTreeState:"clean", BuildDate:"2020-06-01T22:20:10Z", GoVersion:"go1.12.17b4", Compiler:"gc", Platform:"linux/amd64"}

therefore bitnami/kubectl image in hooks could not be downloaded

Failed to apply default image tag "bitnami/kubectl:1.14+": couldn't parse image reference "bitnami/kubectl:1.14+": invalid reference format


I tested it with GCP which contains +

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner August 10, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants