fix(kuma-cp): do not update unchanged insights

[parkanzky]

Signed-off-by: Paul Parkanzky [email protected]

Summary

DataplaneInsights-related resources include a monotonically increasing "generation" field, which is updated regardless of whether the resource has changed. This causes reconciliation within KDS to see them as changing when they have not. Added a ResourceMapper to zero out this field on Global control plane.

Full changelog

• Fix issue where Dataplane-related Insights are unnecessarily reconciled.

Issues resolved

Fix #3783

Documentation

• Link to the website documentation PR

Testing

• Unit tests
• E2E tests
• Manual testing on Universal
• Manual testing on Kubernetes

Backwards compatibility

• Update UPGRADE.md with any steps users will need to take when upgrading.
• Add backport-to-stable label if the code follows our backporting policy

[codecov-commenter]

Codecov Report

Merging #3819 (f4e0f21) into master (a5acfb2) will increase coverage by 0.04%.
The diff coverage is 84.00%.

@@            Coverage Diff             @@
##           master    #3819      +/-   ##
==========================================
+ Coverage   55.86%   55.91%   +0.04%     
==========================================
  Files         901      901              
  Lines       53554    53578      +24     
==========================================
+ Hits        29920    29960      +40     
+ Misses      21237    21216      -21     
- Partials     2397     2402       +5     

Impacted Files	Coverage Δ
pkg/kds/context/context.go	66.66% <84.00%> (+5.79%)	⬆️
pkg/core/resources/manager/cache.go	83.11% <0.00%> (-5.20%)	⬇️
...core/resources/apis/mesh/zz_generated.resources.go	74.57% <0.00%> (+1.02%)	⬆️
pkg/xds/generator/direct_access_proxy_generator.go	88.76% <0.00%> (+1.12%)	⬆️
pkg/mads/server/server.go	84.25% <0.00%> (+1.85%)	⬆️
pkg/defaults/components.go	87.75% <0.00%> (+4.08%)	⬆️
pkg/xds/cache/once/once.go	100.00% <0.00%> (+5.00%)	⬆️
pkg/xds/cache/once/cache.go	87.17% <0.00%> (+5.12%)	⬆️
pkg/plugins/runtime/gateway/route/sorter.go	66.66% <0.00%> (+5.12%)	⬆️
pkg/core/tokens/default_signing_key.go	72.22% <0.00%> (+5.55%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5acfb2...f4e0f21. Read the comment docs.