Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): make sure controllers start after leader election #3666

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jan 7, 2022

Summary

This PR adds an intercept to Manager.Add calls to save Controllers to be Added after leader election.

Closes #3611

@michaelbeaumont michaelbeaumont marked this pull request as ready for review January 7, 2022 14:33
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner January 7, 2022 14:33
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #3666 (55f47b1) into master (999b7a8) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3666   +/-   ##
=======================================
  Coverage   50.90%   50.91%           
=======================================
  Files         927      927           
  Lines       56508    56531   +23     
=======================================
+ Hits        28766    28781   +15     
- Misses      25453    25459    +6     
- Partials     2289     2291    +2     
Impacted Files Coverage Δ
pkg/plugins/bootstrap/k8s/plugin.go 1.11% <0.00%> (-0.17%) ⬇️
pkg/defaults/components.go 86.95% <0.00%> (-4.35%) ⬇️
pkg/core/resources/model/rest/resource.go 67.94% <0.00%> (-1.29%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 86.95% <0.00%> (+1.08%) ⬆️
pkg/insights/resyncer.go 73.61% <0.00%> (+2.45%) ⬆️
pkg/events/eventbus.go 92.59% <0.00%> (+7.40%) ⬆️
pkg/plugins/runtime/gateway/route/sorter.go 71.79% <0.00%> (+10.25%) ⬆️
pkg/insights/components.go 100.00% <0.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 999b7a8...55f47b1. Read the comment docs.

@michaelbeaumont michaelbeaumont enabled auto-merge (squash) January 7, 2022 16:19
@michaelbeaumont michaelbeaumont merged commit 728704b into kumahq:master Jan 7, 2022
@michaelbeaumont michaelbeaumont deleted the feat/manager_wrapper_leader branch January 7, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leader election seems broken for Kubernetes
3 participants