Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/onsi/gomega from 1.13.0 to 1.16.0 #2657

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 24, 2021

Bumps github.com/onsi/gomega from 1.13.0 to 1.16.0.

Release notes

Sourced from github.com/onsi/gomega's releases.

v1.16.0

Features

  • feat: HaveHTTPStatus multiple expected values (#465) [aa69f1b]
  • feat: HaveHTTPHeaderWithValue() matcher (#463) [dd83a96]
  • feat: HaveHTTPBody matcher (#462) [504e1f2]
  • feat: formatter for HTTP responses (#461) [e5b3157]

v1.15.0

1.15.0

Fixes

The previous version (1.14.0) introduced a change to allow Eventually and Consistently to support functions that make assertions. This was accomplished by overriding the global fail handler when running the callbacks passed to Eventually/Consistently in order to capture any resulting errors. Issue #457 uncovered a flaw with this approach: when multiple Eventuallys are running concurrently they race when overriding the singleton global fail handler.

1.15.0 resolves this by requiring users who want to make assertions in Eventually/Consistently call backs to explicitly pass in a function that takes a Gomega as an argument. The passed-in Gomega instance can be used to make assertions. Any failures will cause Eventually to retry the callback. This cleaner interface avoids the issue of swapping out globals but comes at the cost of changing the contract introduced in v1.14.0. As such 1.15.0 introduces a breaking change with respect to 1.14.0 - however we expect that adoption of this feature in 1.14.0 remains limited.

In addition, 1.15.0 cleans up some of Gomega's internals. Most users shouldn't notice any differences stemming from the refactoring that was made.

v1.14.0

1.14.0

Features

  • gmeasure.SamplingConfig now suppers a MinSamplingInterval [e94dbca]
  • Eventually and Consistently support functions that make assertions [2f04e6e]
    • Eventually and Consistently now allow their passed-in functions to make assertions. These assertions must pass or the function is considered to have failed and is retried.
    • Eventually and Consistently can now take functions with no return values. These implicitly return nil if they contain no failed assertion. Otherwise they return an error wrapping the first assertion failure. This allows these functions to be used with the Succeed() matcher.
    • Introduce InterceptGomegaFailure - an analogue to InterceptGomegaFailures - that captures the first assertion failure and halts execution in its passed-in callback.

Fixes

  • Call Verify GHTTPWithGomega receiver funcs (#454) [496e6fd]
  • Build a binary with an expected name (#446) [7356360]
Changelog

Sourced from github.com/onsi/gomega's changelog.

1.16.0

Features

  • feat: HaveHTTPStatus multiple expected values (#465) [aa69f1b]
  • feat: HaveHTTPHeaderWithValue() matcher (#463) [dd83a96]
  • feat: HaveHTTPBody matcher (#462) [504e1f2]
  • feat: formatter for HTTP responses (#461) [e5b3157]

1.15.0

Fixes

The previous version (1.14.0) introduced a change to allow Eventually and Consistently to support functions that make assertions. This was accomplished by overriding the global fail handler when running the callbacks passed to Eventually/Consistently in order to capture any resulting errors. Issue #457 uncovered a flaw with this approach: when multiple Eventuallys are running concurrently they race when overriding the singleton global fail handler.

1.15.0 resolves this by requiring users who want to make assertions in Eventually/Consistently call backs to explicitly pass in a function that takes a Gomega as an argument. The passed-in Gomega instance can be used to make assertions. Any failures will cause Eventually to retry the callback. This cleaner interface avoids the issue of swapping out globals but comes at the cost of changing the contract introduced in v1.14.0. As such 1.15.0 introduces a breaking change with respect to 1.14.0 - however we expect that adoption of this feature in 1.14.0 remains limited.

In addition, 1.15.0 cleans up some of Gomega's internals. Most users shouldn't notice any differences stemming from the refactoring that was made.

1.14.0

Features

  • gmeasure.SamplingConfig now suppers a MinSamplingInterval [e94dbca]
  • Eventually and Consistently support functions that make assertions [2f04e6e]
    • Eventually and Consistently now allow their passed-in functions to make assertions. These assertions must pass or the function is considered to have failed and is retried.
    • Eventually and Consistently can now take functions with no return values. These implicitly return nil if they contain no failed assertion. Otherwise they return an error wrapping the first assertion failure. This allows these functions to be used with the Succeed() matcher.
    • Introduce InterceptGomegaFailure - an analogue to InterceptGomegaFailures - that captures the first assertion failure and halts execution in its passed-in callback.

Fixes

  • Call Verify GHTTPWithGomega receiver funcs (#454) [496e6fd]
  • Build a binary with an expected name (#446) [7356360]
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner August 24, 2021 11:43
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 24, 2021
@jpeach
Copy link
Contributor

jpeach commented Aug 24, 2021

@Mergifyio rebase

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.13.0 to 1.16.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.13.0...v1.16.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2021

Command rebase: success

Branch has been successfully rebased

@bartsmykla bartsmykla force-pushed the dependabot/go_modules/github.com/onsi/gomega-1.16.0 branch from 49e6d2f to f7b9c04 Compare August 24, 2021 23:48
@codecov-commenter
Copy link

Codecov Report

Merging #2657 (f7b9c04) into master (14b527b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2657      +/-   ##
==========================================
- Coverage   51.96%   51.95%   -0.02%     
==========================================
  Files         871      871              
  Lines       49505    49505              
==========================================
- Hits        25727    25720       -7     
- Misses      21698    21707       +9     
+ Partials     2080     2078       -2     
Impacted Files Coverage Δ
pkg/insights/components.go 70.00% <0.00%> (-30.00%) ⬇️
pkg/core/resources/store/customizable_store.go 77.77% <0.00%> (-11.12%) ⬇️
.../core/managers/apis/ratelimit/ratelimit_manager.go 35.48% <0.00%> (-9.68%) ⬇️
pkg/plugins/resources/memory/store.go 77.71% <0.00%> (-4.35%) ⬇️
pkg/insights/resyncer.go 66.16% <0.00%> (-1.51%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 82.75% <0.00%> (-1.15%) ⬇️
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/core/resources/manager/cache.go 84.41% <0.00%> (+2.59%) ⬆️
pkg/kds/client/sink.go 52.27% <0.00%> (+4.54%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b527b...f7b9c04. Read the comment docs.

@jpeach jpeach merged commit 9419f21 into master Aug 25, 2021
@jpeach jpeach deleted the dependabot/go_modules/github.com/onsi/gomega-1.16.0 branch August 25, 2021 03:43
mergify bot pushed a commit that referenced this pull request Aug 25, 2021
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.13.0 to 1.16.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.13.0...v1.16.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 9419f21)
bartsmykla pushed a commit that referenced this pull request Aug 25, 2021
#2666)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.13.0 to 1.16.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.13.0...v1.16.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 9419f21)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
nikita15p pushed a commit to nikita15p/kuma that referenced this pull request Sep 28, 2021
…q#2657)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.13.0 to 1.16.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.13.0...v1.16.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
nikita15p pushed a commit to nikita15p/kuma that referenced this pull request Sep 28, 2021
…q#2657)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.13.0 to 1.16.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.13.0...v1.16.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants