Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp) add route and virtual host configuration helpers #2517

Merged
merged 1 commit into from
Aug 9, 2021
Merged

chore(kuma-cp) add route and virtual host configuration helpers #2517

merged 1 commit into from
Aug 9, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Aug 9, 2021

Summary

Add configuration helper adaptors for envoy VirtualHost and
RouteConfiguration types.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Add configuration helper adaptors for envoy VirtualHost and
RouteConfiguration types.

Signed-off-by: James Peach <[email protected]>
@jpeach jpeach requested a review from a team as a code owner August 9, 2021 00:48
@codecov-commenter
Copy link

Codecov Report

Merging #2517 (31b61ce) into master (2e3ace0) will increase coverage by 0.04%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2517      +/-   ##
==========================================
+ Coverage   52.18%   52.22%   +0.04%     
==========================================
  Files         865      865              
  Lines       48284    48295      +11     
==========================================
+ Hits        25196    25222      +26     
+ Misses      21047    21029      -18     
- Partials     2041     2044       +3     
Impacted Files Coverage Δ
pkg/xds/envoy/routes/v3/configurer.go 25.00% <25.00%> (ø)
pkg/xds/envoy/routes/configurers.go 100.00% <100.00%> (ø)
...kg/xds/envoy/routes/route_configuration_builder.go 84.00% <100.00%> (+3.04%) ⬆️
pkg/xds/envoy/routes/virtual_host_builder.go 84.00% <100.00%> (+3.04%) ⬆️
pkg/xds/cache/once/cache.go 87.17% <0.00%> (-7.70%) ⬇️
pkg/core/resources/manager/cache.go 81.81% <0.00%> (ø)
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/insights/resyncer.go 66.38% <0.00%> (+1.68%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3ace0...31b61ce. Read the comment docs.

@jpeach jpeach merged commit 4012ece into kumahq:master Aug 9, 2021
mergify bot pushed a commit that referenced this pull request Aug 9, 2021
Add configuration helper adaptors for envoy VirtualHost and
RouteConfiguration types.

Signed-off-by: James Peach <[email protected]>
(cherry picked from commit 4012ece)
jpeach added a commit that referenced this pull request Aug 9, 2021
… (#2536)

Add configuration helper adaptors for envoy VirtualHost and
RouteConfiguration types.

Signed-off-by: James Peach <[email protected]>
(cherry picked from commit 4012ece)

Co-authored-by: James Peach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants