refactor(xds) rename logger to have consistent naming style

[burntcarrot]

Signed-off-by: Aadhav Vignesh [email protected]

Summary

rename logger names to be consistent in the xDS server package

Full changelog

• [Implement ...]
• [Fix ...]

Issues resolved

Updates #2313

Documentation

• Link to the website documentation PR

Testing

• Unit tests
• E2E tests
• Manual testing on Universal
• Manual testing on Kubernetes

Backwards compatibility

• Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

[CLAassistant]

All committers have signed the CLA.

[codecov-commenter]

Codecov Report

Merging #2375 (3647840) into master (b0c72d1) will increase coverage by 0.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2375      +/-   ##
==========================================
+ Coverage   52.13%   52.54%   +0.40%     
==========================================
  Files         874      878       +4     
  Lines       47826    47867      +41     
==========================================
+ Hits        24936    25151     +215     
+ Misses      20865    20664     -201     
- Partials     2025     2052      +27     

Impacted Files	Coverage Δ
...g/xds/server/callbacks/dataplane_status_tracker.go	97.64% <ø> (ø)
pkg/core/resources/model/rest/resource.go	67.94% <0.00%> (-1.29%)	⬇️
...kg/plugins/resources/k8s/native/pkg/test/within.go	100.00% <0.00%> (ø)
api/internal/util/proto/types.go	100.00% <0.00%> (ø)
...k8s/native/controllers/proxytemplate_controller.go	0.00% <0.00%> (ø)
api/internal/util/proto/proto.go	70.00% <0.00%> (ø)
api/mesh/v1alpha1/dataplane_helpers.go	80.16% <0.00%> (+1.68%)	⬆️
pkg/core/resources/manager/cache.go	84.41% <0.00%> (+2.59%)	⬆️
pkg/plugins/resources/memory/store.go	82.06% <0.00%> (+4.34%)	⬆️
api/mesh/v1alpha1/dataplane_insight_helpers.go	83.33% <0.00%> (+5.20%)	⬆️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c72d1...3647840. Read the comment docs.

[jpeach]

@burntcarrot I pinged slack to see if anyone depends on these names. No-one has mentioned any concerns so I'd say we are good here.

Could you please update the Github tags to say "Updates #2313" rather than "fixes"? That way, the issue will remain open and we can make more PRs against it.

[burntcarrot]

Yeah, I have been keeping an eye on the Slack from quite a while, and I guess we're safe to move forward.

[burntcarrot]

I've updated it. In case anyone raises some concerns regarding the logger names in the future, we can safely issue more fixes. This would hopefully prevent any services running dependent on the logger names subject to breaking changes.

@jpeach PR is ready for review, could you please take some time to review it?

[burntcarrot]

Just out of curiosity, are the changes meant to be a part of the next release, or are you trying to push the changes to be a part of a later release, allowing room for more people to raise concerns?

[jpeach]

Nice.

[jpeach]

Just out of curiosity, are the changes meant to be a part of the next release, or are you trying to push the changes to be a part of a later release, allowing room for more people to raise concerns?

I don't have a strong opinion. I'm inclined to backport this to the 1.2 branch, but I'll ask around the maintainers.

[ccfishk]

lgtm.

[ccfishk]

consistent naming is good.

[burntcarrot]

Any updates? I guess it's better to merge it now, in order to make it available for the next release.