Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) inject ingress.kubernetes.io/service-upstream #1608

Merged
merged 5 commits into from
Mar 2, 2021

Conversation

nickolaev
Copy link
Contributor

@nickolaev nickolaev commented Feb 26, 2021

Summary

Automatically inject ingress.kubernetes.io/service-upstream to all K8s Services, for the purposes of exposing Service Mesh service through the GW.
Previously users had to do this on their own.

Documentation

Signed-off-by: Nikolay Nikolaev <[email protected]>
@nickolaev nickolaev requested a review from a team as a code owner February 26, 2021 03:30
@nickolaev
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2021

Command update: success

Branch has been successfully updated

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I see we are not covering the case when someone is injecting Kuma on the Pod, not the namespace. But since it's like ~95% cases, it should be fine 👌

@nickolaev nickolaev force-pushed the chore/service_controller branch from 31af9be to aeb0181 Compare March 2, 2021 09:26
@nickolaev nickolaev merged commit 57d751e into master Mar 2, 2021
@nickolaev nickolaev deleted the chore/service_controller branch March 2, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants