feat(kuma-cp) add versions endpoint #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `/versions/` API endpoint which will return the object with supported versions of dependencies (currently supported versions of envoy for kumaDPs) Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
nickolaev
reviewed
Feb 23, 2021
| Expect(data).ToNot(BeNil()) | ||
| Expect(data.KumaDp).ToNot(BeNil()) | ||
| Expect(data.KumaDp["1.0.8"]).ToNot(BeNil()) | ||
| Expect(data.KumaDp["1.0.8"].Envoy).To(Equal("1.16.2")) |
There was a problem hiding this comment.
I don't think there is a need to check each and every entry ;) Maybe just first,middle,last?
There was a problem hiding this comment.
I'm checking it as an additional layer for us to be sure we are presenting expected versions
jakubdyszkiewicz
requested changes
Feb 23, 2021
As suggested by Jakub in the past form it wouldn't work as it has to be compiled into kuma-cp binary Signed-off-by: Bart Smykla <[email protected]>
|
@jakubdyszkiewicz as you suggested, embeded it |
jakubdyszkiewicz
approved these changes
Feb 23, 2021
Removed unnecessary error from function returning versions endpoint handler Signed-off-by: Bart Smykla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
/versionsendpointThe versions which are present in a json file, were taken from envoys included in every release starting from
1.0.0by looking into Dockerfile of our image containing kuma-dp (i.e. https://github.com/kumahq/kuma/blob/1.0.0/tools/releases/dockerfiles/Dockerfile.kuma-dp#L2)ref.
Documentation