feat(kuma-cp) XDS extensions and new matcher strategy #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
nickolaev
reviewed
Feb 1, 2021
| @@ -49,6 +49,56 @@ func SelectDataplanePolicy(dataplane *mesh.DataplaneResource, policies []Datapla | |||
| return bestPolicy | |||
| } | |||
|
|
|||
| // SelectInboundDataplanePolicies given a Dataplane definition and a list of DataplanePolicy returns the "best matching" DataplanePolicy for each inbound separately. | |||
| // A DataplanePolicy for an inbound is considered a match if the inbound matches all the tags listed in selector of the DataplanePolicy. | |||
There was a problem hiding this comment.
Should tags have weights?
I mean should kuma.io/zone should be outweighting app/version ?
There was a problem hiding this comment.
We could, I think we even talked about this once, but
- That complicates the matching mechanism, we would need to add some parameterization of tag weights - seems like a breaking change
- Definitely out of scope of this PR, since it touches all matchers
If I were to improve something about the matching mechanism in Kuma, I'd try to support negate cases or aggregation of many policies instead of "only match the most specific"
nickolaev
approved these changes
Feb 2, 2021
lobkovilya
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introducing Hooks, a way to extend Kuma with XDS modification. You can create a new project, have Kuma as a dependency, build a Bootstrap plugin that plugs in XDS hook.
Right now I created one Hook that operates on ResourceSet which allows essentially to do everything you want with XDS resources (add, modify, remove).
The ResourceSetHook may have a slight performance hit, because you need to iterate over all resources of one type. Let's say you want to modify inbound listener, you need to iterate over all listeners. I don't think this is noticeable performance hit, but I left a room to introduce more specific Hooks for builders if needed.
I also introduced a new matching strategy. Instead of matching DataplanePolicy on any inbound and applying on a all resources of the dataplane, you can now match DataplanePolicy on individual inbounds.
Documentation