chore(*) update ecs examples #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 19, 2021 10:22
Signed-off-by: Nikolay Nikolaev <[email protected]>
Signed-off-by: Nikolay Nikolaev <[email protected]>
Signed-off-by: Nikolay Nikolaev <[email protected]>
Signed-off-by: Nikolay Nikolaev <[email protected]>
Signed-off-by: Nikolay Nikolaev <[email protected]>
examples/ecs/kuma-cp-remote.yaml
Outdated
| @@ -280,6 +345,9 @@ Resources: | |||
| Essential: true | |||
| User: '5678' | |||
| Environment: | |||
| - Name: KUMA_DATAPLANE_RUNTIME_TOKEN | |||
| # generated with "wget --header='Content-Type: application/json' --post-data='{\"mesh\": \"default\", \"type\": \"ingress\"}' -qO- http://localhost:5681/tokens" | |||
| Value: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJOYW1lIjoiIiwiTWVzaCI6ImRlZmF1bHQiLCJUYWdzIjp7fSwiVHlwZSI6ImluZ3Jlc3MifQ.62MCnX4pCJztiLsqDSOopKxCDbxGstFrGZ1jboPOcoA | |||
There was a problem hiding this comment.
How does it work? The signing key for dataplane token is changing with every restart if you don't use persistent storage.
Should we instruct the users to replace it with the value generated after deploying global CP and generating the token?
There was a problem hiding this comment.
Oh that now makes much more sense, maybe I should split the ingress to a separate template and instruct to actually generate the token as with the regular workload.
There was a problem hiding this comment.
I think that makes sense
jakubdyszkiewicz
approved these changes
Jan 20, 2021
Signed-off-by: Nikolay Nikolaev <[email protected]>
nickolaev
force-pushed
the
chore/update_ecs_example
branch
from
e9e5ff3 to
07e0c15
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jan 20, 2021
* fix(*) bootstrap pem decode error check * chore(*) bump default version to 1.0.5 * chore(*) make basic standalone work * chore(*) make multizone work * docs(*) update README * chore(*) split ingress to a separate template Signed-off-by: Nikolay Nikolaev <[email protected]> (cherry picked from commit 0362bca)
nickolaev
pushed a commit
that referenced
this pull request
Jan 20, 2021
* fix(*) bootstrap pem decode error check * chore(*) bump default version to 1.0.5 * chore(*) make basic standalone work * chore(*) make multizone work * docs(*) update README * chore(*) split ingress to a separate template Signed-off-by: Nikolay Nikolaev <[email protected]> (cherry picked from commit 0362bca) Co-authored-by: Nikolay Nikolaev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the ECS examples to reflect the latest developments
Documentation