chore(*) outbound reconciler for Universal #1422
Conversation
Signed-off-by: Nikolay Nikolaev <[email protected]>
pkg/dns/resolver/resolver.go
Outdated
| @@ -47,6 +48,12 @@ func (s *dnsResolver) SetVIPs(list vips.List) { | |||
| } | |||
| } | |||
|
|
|||
| func (s *dnsResolver) GetVIPs() vips.List { | |||
| s.Lock() | |||
There was a problem hiding this comment.
RLock() and RUnlock()
| } | ||
|
|
||
| const ( | ||
| tickInterval = 500 * time.Millisecond |
There was a problem hiding this comment.
That cannot be hardcoded IMHO. I think the easiest way here is to just take a value from XDS Interval. There is no point in updating every 0,5s when the XDS interval is for example 10s.
|
|
||
| var log = core.Log.WithName("dns-vips-allocator") | ||
|
|
||
| type OutboundsLoop struct { |
There was a problem hiding this comment.
how about VIPOutboundsReconciller?
| "github.com/kumahq/kuma/pkg/dns" | ||
| ) | ||
|
|
||
| var log = core.Log.WithName("dns-vips-allocator") |
There was a problem hiding this comment.
name is not right
Signed-off-by: Nikolay Nikolaev <[email protected]>
|
@Mergifyio update |
|
Command
|
|
|
nickolaev
changed the title
* chore(*) outbound reconciler for Universal Signed-off-by: Nikolay Nikolaev <[email protected]> (cherry picked from commit 22a1126)
* chore(*) outbound reconciler for Universal Signed-off-by: Nikolay Nikolaev <[email protected]> (cherry picked from commit 22a1126) Co-authored-by: Nikolay Nikolaev <[email protected]>
Summary
On Universal, updating outbands is called only when there is a new VIP coming. This breaks when we add more data planes but no new VIPs.
We make the related functionality to be executed as a component with a ticker every 500ms.
Also update the Universal multi-zone and Hybrid e2e tests to use transparent proxy, which will test that outbound update functionality in more complex scenarios.
Documentation