chore(kuma-cp) change exec probes to http #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
nickolaev
approved these changes
Jan 14, 2021
| envoy_names "github.com/kumahq/kuma/pkg/xds/envoy/names" | ||
| ) | ||
|
|
||
| // OriginPrometheus is a marker to indicate by which ProxyGenerator resources were generated. |
There was a problem hiding this comment.
nit: the comment is about OriginPrometheus -> OriginAdmin
|
Shall we backport? |
…endpoints Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
lobkovilya
reviewed
Jan 15, 2021
| }) | ||
| } | ||
|
|
||
| resources.Add(&core_xds.Resource{ |
There was a problem hiding this comment.
Do we need this cluster if proxy.Dataplane.Spec.GetNetworking().Address == "127.0.0.1"?
There was a problem hiding this comment.
Yes, because we may still use it for Prometheus
lobkovilya
approved these changes
Jan 18, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jan 18, 2021
Signed-off-by: Jakub Dyszkiewicz <[email protected]> (cherry picked from commit c1fa394)
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Jan 19, 2021
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the way we probe Kuma DP sidecar.
So far we were using exec healthchecks and
/readyendpoint on Admin API. Admin API is exposed only on loopback interface for security reasons.This PR exposes
/readyto the outside of the container, but only the/readyendpoint. This way we can change probe from exec to httpReason
Containerd 1.4.0 had a bug of Pods being stuck at Terminating status when there was a container with exec probe.
awslabs/amazon-eks-ami#563