fix(kumactl) backoff durations validation #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two bugs, one was happening when there was only seconds in timeout durations provided (`1s`) as the validator was not checking if seconds are provided and assuming that if nanoseconds field is empty, it means the value is equal 0 and then rejecting valid values. The second bug was that we were not validating `maxInterval` values of the backOff properties Signed-off-by: Bart Smykla <[email protected]>
jakubdyszkiewicz
approved these changes
Dec 22, 2020
mergify bot
pushed a commit
that referenced
this pull request
Dec 22, 2020
There were two bugs, one was happening when there was only seconds in timeout durations provided (`1s`) as the validator was not checking if seconds are provided and assuming that if nanoseconds field is empty, it means the value is equal 0 and then rejecting valid values. The second bug was that we were not validating `maxInterval` values of the backOff properties Signed-off-by: Bart Smykla <[email protected]> (cherry picked from commit a7c1f39)
nickolaev
pushed a commit
that referenced
this pull request
Dec 22, 2020
There were two bugs, one was happening when there was only seconds in timeout durations provided (`1s`) as the validator was not checking if seconds are provided and assuming that if nanoseconds field is empty, it means the value is equal 0 and then rejecting valid values. The second bug was that we were not validating `maxInterval` values of the backOff properties Signed-off-by: Bart Smykla <[email protected]> (cherry picked from commit a7c1f39) Co-authored-by: Bart Smykla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two bugs, one was happening when there was only seconds in
timeout durations provided (
1s) as the validator was not checking ifseconds are provided and assuming that if nanoseconds field is empty, it
means the value is equal 0 and then rejecting valid values.
The second bug was that we were not validating
maxIntervalvalues ofthe backOff properties