fix(kuma-cp): Rename field dpVersion to kumaDp in Version schema #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacek Ewertowski <[email protected]>
jakubdyszkiewicz
approved these changes
Dec 10, 2020
mergify bot
pushed a commit
that referenced
this pull request
Dec 11, 2020
Signed-off-by: Jacek Ewertowski <[email protected]> (cherry picked from commit ae1ba3d) # Conflicts: # api/mesh/v1alpha1/dataplane.pb.go # api/mesh/v1alpha1/dataplane_insight.pb.go # api/mesh/v1alpha1/dataplane_insight.proto # api/mesh/v1alpha1/dataplane_insight_helpers.go # pkg/xds/server/dataplane_status_tracker_test.go
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Dec 11, 2020
Signed-off-by: Jacek Ewertowski <[email protected]>
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Dec 11, 2020
Signed-off-by: Jacek Ewertowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jacek Ewertowski [email protected]
Summary
This change is necessary to proper deserialization of
DiscoveryRequest.Node.Metadataindataplane_status_tracker.Full changelog
dpVersiontokumaDpin schema ofapi/mesh/v1alpha/Version.Issues resolved
Fix #1283