-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(kuma-cp) deploy many instances using HELM #1208
Conversation
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a really nice change to me. We may want to investigate some default HPA policies if this is a common use case, I think @tharun208 had some ideas in the initial Helm chart implementation.
Edit: just saw your issue #1207, looks like we're on the same page. Happy to take a stab at that.
Assigned it to you for visibility. |
@@ -16,6 +16,8 @@ controlPlane: | |||
|
|||
kdsGlobalAddress: "" | |||
|
|||
replicas: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know why it is one by default, but in reality - do we advise people to run a single copy of the CP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On production? No, you should run at least 2 for HA (and probably with a PodAffinity settings that two of them are not spawned on the same Node). Ideally, this will be controlled by Horizontal Pod Autoscaler, hence the issue I created.
So what's your suggestion for the default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK lets go for the HPA apraoch and leave this one as 1
.
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]> (cherry picked from commit fd0bf9f) # Conflicts: # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Summary
Add capability to deploy many instances of Kuma by parametrizing HELM. Kuma is meant to be scaled horizontally. I also parametrized Ingress deployment.
Full changelog
RestartKuma
for E2E since it's not used anywhereDocumentation