chore(kuma-cp) rename 'kumactl generate dataplane-token' CLI arg #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <[email protected]>
nickolaev
reviewed
Nov 24, 2020
| @@ -13,7 +13,8 @@ type generateDataplaneTokenContext struct { | |||
| *kumactl_cmd.RootContext | |||
|
|
|||
| args struct { | |||
| dataplane string | |||
| dataplane string // Deprecated: remove in next major version of Kuma 1.1 | |||
There was a problem hiding this comment.
We have to find a way to track these deprecations. Either we have a fixed tag, like Deprecated: or we track in a dedicated doc.
nickolaev
approved these changes
Nov 24, 2020
jakubdyszkiewicz
approved these changes
Nov 24, 2020
|
Make sure to update docs |
Signed-off-by: Ilya Lobkov <[email protected]>
nickolaev
suggested changes
Nov 25, 2020
|
That's weird, I looked through all documentation, but it's already correct: |
nickolaev
approved these changes
Nov 26, 2020
mergify bot
pushed a commit
that referenced
this pull request
Nov 26, 2020
(cherry picked from commit d3192ce)
nickolaev
pushed a commit
that referenced
this pull request
Nov 27, 2020
…) (#1221) (cherry picked from commit d3192ce) Co-authored-by: Ilya Lobkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilya Lobkov [email protected]
Summary
rename
--dataplaneto--name