chore(*) handle resources that are global scoped #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
nickolaev
reviewed
Nov 6, 2020
nickolaev
reviewed
Nov 6, 2020
| @@ -10,6 +10,9 @@ import ( | |||
|
|
|||
| const ( | |||
| DefaultMesh = "default" | |||
| // NoMesh defines a marker that resource is not bound to a Mesh. | |||
| // Resources not bound to a mesh (ScopeGlobal) should have an empty string in Mesh field. | |||
| NoMesh = "" | |||
There was a problem hiding this comment.
hmm, can we use some special character/string instead? Not sure if "" is the universal way to designate NoMesh. How is this encoded in YAML/JSON?
There was a problem hiding this comment.
"Not sure if "" is the universal way to designate NoMesh " Hm, why not?
When string is empty, mesh field is excluded from the JSON/YAML.
nickolaev
approved these changes
Nov 6, 2020
lobkovilya
reviewed
Nov 9, 2020
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
lobkovilya
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the fact that Zone is bound to a Mesh.
We have two resources that are not abound to a mesh - Zone and Mesh.
Our core resources has
meshfield in all resources.Before this PR:
meshfield withnamefielddefaultin amesh. We cannot do this, because Zone is not really bound to a Mesh and default Mesh may not be even in the system.With this PR:
meshfield if resource is of ScopeGlobalFull changelog
meshis emptyIssues resolved
Fix #1023
Documentation