chore(*) improve DP insights API filtering #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolay Nikolaev <[email protected]>
|
@nickolaev, Also we need to add the filter option for |
Please give an example of the CLI command. |
we are already having an option in CLI to filter |
added 3 commits
October 26, 2020 12:13
Signed-off-by: Nikolay Nikolaev <[email protected]>
Signed-off-by: Nikolay Nikolaev <[email protected]>
tharun208
approved these changes
Oct 27, 2020
lobkovilya
reviewed
Oct 30, 2020
| return isnil(a) | ||
| } | ||
| default: | ||
| return func(a interface{}) bool { |
There was a problem hiding this comment.
If a query has ?gateway=some_garbage_value does it mean it returns gateways? Can we somehow validate this?
added 2 commits
November 3, 2020 14:53
Signed-off-by: Nikolay Nikolaev <[email protected]>
lobkovilya
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve the API to have better filtering for dataplane insights, such that this request will now work ->
curl http://localhost:5681/dataplanes+insights?gateway=false&ingress=false