feat(kuma-cp) use dp server port instead of catalog #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobkovilya
approved these changes
Oct 19, 2020
nickolaev
approved these changes
Oct 19, 2020
jakubdyszkiewicz
force-pushed
the
chore/token-validation
branch
from
8c7103e to
6d5f397
Compare
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
force-pushed
the
feat/kuma-dp-drop-catalog
branch
from
3e49ff5 to
95fe6f4
Compare
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
…atalog Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Until now, DP requested a control plane on the API port for the catalog and then it used the bootstrap URL provided by CP to contact it again for the bootstrap configuration. This PR changes this behavior so we contact CP directly on DP Server port (the one for bootstrap, xds, sds etc.)
Motivation:
Compatibility
Although it is a breaking change on Universal when upgrade (a user needs to update --cp-address manually to the new port) because I kept catalog as a part of
:5681/catalog, the old Dataplane will be able to connect to the new Control Plane.Documentation